v5.1 doesn't generate tags about github-tag-action HOT 15 CLOSED

This isn't fixed, as can be seen by issues #46 and #47
This shouldn't have been closed, can you please re-open it @mathieudutour ?

from github-tag-action.

@chrisjohnson00 What was the branch you pushed to?

from github-tag-action.

main

from github-tag-action.

@chrisjohnson00 Sorry, cannot reproduce this yet.

Can you also share the workflow? The part where you are using the two actions?

from github-tag-action.

Sure, here you go

name: Create Release

on:
  push:
    branches: [ 'main' ]

jobs:
  create_release:
    runs-on: ubuntu-18.04
    name: Create Release
    steps:
      - uses: actions/checkout@v2
      - name: Bump version and push tag
        id: tag_version
        uses: mathieudutour/github-tag-action@v5
        with:
          github_token: ${{ secrets.REPO_ONLY }}
          release_branches: main
          default_bump: patch
      - name: Create a GitHub release
        uses: actions/create-release@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          tag_name: ${{ steps.tag_version.outputs.new_tag }}
          release_name: ${{ steps.tag_version.outputs.new_tag }}
          body: ${{ steps.tag_version.outputs.changelog }}

The REPO_ONLY token is used because I need workflows to be triggered from the creation of the tag.

from github-tag-action.

Here's an example where the action fails:
https://github.com/chrisjohnson00/solaredge-prometheus-exporter/actions/runs/388022672

from github-tag-action.

Thanks.

from github-tag-action.

I'm in the same situation. Just upgraded to v5.1 to make use of the new 'custom_release_rules' input. However, no tag is being generated now, therefore the workflow is falling on a subsequent step that requires the new tag name.

from github-tag-action.

Same thing is happening to me. Works on v5

from github-tag-action.

According to mathieu's changelog, the only thing different from v5 is that in the docs he references v5.1.

I can confirm also that v5 works.

from github-tag-action.

According to mathieu's changelog, the only thing different from v5 is that in the docs he references v5.1.

I can confirm also that v5 works.

Yes, but you'll also notice that v5.1 was "released" yesterday, yet this Issue is 9 days old. This means the v5.1 release was deleted and re-created.

from github-tag-action.

no it wasn't, I just forgot to create release but the tag existed.

from github-tag-action.

no it wasn't, I just forgot to create release but the tag existed.

Ahh, I see.
If you treat any merge to your default branch as a release-able event, check out this workflow, it'll do all the release activities.
https://github.com/chrisjohnson00/solaredge-prometheus-exporter/blob/main/.github/workflows/auto-release.yaml

FWIW - It uses a different token for creating the tag, this is to ensure that other flows are triggered, for example to create a latest and vX.Y.Z tagged container.
It does require adopting a commit and PR title format, but it's a "standard" convention: https://www.conventionalcommits.org/en/v1.0.0/

from github-tag-action.

This isn't fixed, as can be seen by issues #46 and #47
This shouldn't have been closed, can you please re-open it @mathieudutour ?

And also Dependabot as expected suggested an update to v5.1, which would break any workflow that merges that suggested PR.

from github-tag-action.

This isn't fixed, as can be seen by issues #46 and #47
This shouldn't have been closed, can you please re-open it @mathieudutour ?

@mathieudutour - was this fixed?

from github-tag-action.