Giter Club home page Giter Club logo

Comments (8)

mathieu-bour avatar mathieu-bour commented on June 12, 2024

Thanks for the feature request. I will try to implement this feature, but I do not have any runner running on this architecture at my disposition so I'll try to implement this feature blindly.
When it will be ready, could you possibly test the feature for your use case?

from setup-sentry-cli.

paresy avatar paresy commented on June 12, 2024

Sure. If you have a feature branch ready ping me and i'll give it a spin!

Thanks!

from setup-sentry-cli.

mathieu-bour avatar mathieu-bour commented on June 12, 2024

Could you possibly try using this following branch?

- uses: mathieu-bour/setup-sentry-cli@feat/amdv7-arch

from setup-sentry-cli.

paresy avatar paresy commented on June 12, 2024

It works on ARMv7 (32Bit), but it probably won't work on ARM64 (aarch64) yet. At least i haven't seen a code-path in the PR for it yet. Is that right? I will run an ARM64 build tomorrow and give you "tested" results. Thanks for the quick patch so far!

(This link is still missing as far as i have seen: SENTRY_DOWNLOAD_Linux_aarch64="https://downloads.sentry-cdn.com/sentry-cli/1.64.2/sentry-cli-Linux-aarch64")

from setup-sentry-cli.

mathieu-bour avatar mathieu-bour commented on June 12, 2024

Ok, I was not aware of the ARM versions, etc. I'll define the conditional links for this architecture too.

from setup-sentry-cli.

mathieu-bour avatar mathieu-bour commented on June 12, 2024

The code should be good by now. You can check the integration of the multiple platform/architectures here:

const PLATFORM_MAPPINGS: Record<string, string> = {
'linux-x32': 'Linux-i686',
'linux-x64': 'Linux-x86_64',
'linux-arm': 'Linux-armv7',
'linux-arm64': 'Linux-aarch64',
'darwin-x64': 'Darwin-x86_64',
'darwin-arm64': 'Darwin-arm64',
'win32-x32': 'Windows-i686',
'win32-x64': 'Windows-x86_64',
};

If you get working results, I'll merge the branch into main and publish version 1.2.0.

from setup-sentry-cli.

paresy avatar paresy commented on June 12, 2024

Just wanted to give feedback that i have successfully tested ARMv7 and ARM64 using the feature branch. Great work. Thanks!

from setup-sentry-cli.

mathieu-bour avatar mathieu-bour commented on June 12, 2024

Thank you very much for your feedback. I'll merge the branch and release version 1.2.0. Consider dropping a star!

from setup-sentry-cli.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.