Many sequences are only being partially matched about emoji-regex HOT 7 CLOSED

I've been looking into this over the last few days, and I believe I have a fix, but it's a 2-parter (it will require a fix in regexgen combined with a tweak to the emoji-regex build process). I'll put some PRs together when I next find some spare coding time (I need to test it properly).

from emoji-regex.

@suprMax Thanks for the offer of help. 🙂

My main problem was making sure I actually understood how regexgen worked, especially the optimisation/simplification process. I've now got a PR open to fix the regexgen bug, and I've got another PR ready to go for emoji-regex once that fix is merged and released. I won't submit the emoji-regex PR before then, as it (unintuitively) makes the problem slightly worse without the regexgen fix. Isn't software fun? 😁

from emoji-regex.

cc @devongovett

from emoji-regex.

Same issue with '👩🏽‍🚀' and '👨🏿‍✈️', essentially anything with U+200D

from emoji-regex.

@gilmoreorless any way I could assist you on this noble quest? I resorted to generating a regex containing all emojis for now, but as you can imagine it's quite a long regex. I would like to see it shortened properly.

from emoji-regex.

@gilmoreorless regexgen v1.2.4 has been released, including your fix. I’ll wait for your PR :) Thanks so much for tackling this!

from emoji-regex.

Works perfectly! Thanks for the fix guys!

from emoji-regex.