`typing_extension` imported at run time causing ImportError about pymatgen HOT 4 CLOSED

We don't install typing_extensions in CI but one of our optional dependencies must.

Could be (just guess, didn't check).

So we didn't see the error but #3646 by @ml-evs would have caught this which is why I'm eager to get it merged. Sadly, lots of legacy issues in the way. maybe it makes sense to split out a PR that only adds minimal dependency checking and do all the type stuff in #3646 separately.

Yes I just had a look and there are 700+ pyright errors. It's certainly too much work for a single person and I would see if I could give him a hand on that.

from pymatgen.

Mistakes happen. It's not a big deal especially if we fix them quickly.

We don't install typing_extensions in CI but one of our optional dependencies must. Which means it's available in our CI but not necessarily available in others CI or local machines. So we didn't see the error but #3646 by @ml-evs would have caught this which is why I'm eager to get it merged. Sadly, lots of legacy issues in the way. maybe it makes sense to split out a PR that only adds minimal dependency checking and do all the type stuff in #3646 separately.

from pymatgen.

Help with fixing pyright issues would be hugely appreciated!

from pymatgen.

Thanks for fixing! Just tracked them down and found these were added in 2adde29 (guess we were both too distracted because there were just too many mypy errors), and wondering why unit tests didn't capture such errors (we don't explicitly install typing_extensions in our CI too)?

from pymatgen.