GesturePerformer likely shouldn't be adding the gesture recognizer to the target about direct-manipulation-swift HOT 6 CLOSED

Considered this more while writing the spec for Direct Manipulation; the plan's gesture recognizer property can be optional.

If no gesture recognizer is provided, then the performer can create one and add it to the target.

If a gesture recognizer is provided, then we may only want to add the gesture recognizer to the target if it doesn't already have a view.

from direct-manipulation-swift.

Just want to note that it seems strange to me that the GestureRecognizer is managed by the client and provided to the Draggable Plan.

Seems to me like you'd want to abstract away the GestureRecognizer by having it be privately owned by the Performer.

from direct-manipulation-swift.

If a gesture recognizer already exists then the client needs a way to pass it into the system. For example, iOS provides an edge swipe gesture recognizer on all view controllers.

from direct-manipulation-swift.

I was also of the mind that it should be abstracted away, but making it optional seems like the right approach considering the example you provided.

I attempted to turn Gesturable into a protocol requiring a gesture recognizer. I was thinking customized classes such as Draggable could then vend a panGestureRecognizer, which would be a computed property that casts the protocol-required gesture recognizer. I believe this is similar to how the tableView and collectionView properties work on UITVC and UICVC.

from direct-manipulation-swift.

Could the application of swift generics here aid in any way?

from direct-manipulation-swift.

🎊 My diff is ready for review at http://codereview.cc/D1620

from direct-manipulation-swift.