Giter Club home page Giter Club logo

Comments (2)

abhiomkar avatar abhiomkar commented on June 11, 2024

I think the catalog usage needs to be updated, here the demo of latest checkbox with custom theme:
https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/07/08/19_30_20_273/spec/mdc-checkbox/mixins/container-colors.html?utm_source=golden_json

Here is the usage:
https://github.com/material-components/material-components-web/blob/master/test/screenshot/spec/mdc-checkbox/fixture.scss

I'm transferring this issue to catalog repo.

from material-components-web-catalog.

Yavanosta avatar Yavanosta commented on June 11, 2024

Actually theme demo already removed, but problem was in the way of styling components in demo:

.theme-demo {
  $mdc-theme-primary: #fcb8ab;
  $mdc-theme-secondary: #feeae6;

  @import "@material/checkbox/mdc-checkbox";
}
<div class="theme-demo">
  <div className='mdc-checkbox'>...</div>
</div>

In this case because of this condition wrong class for checkbox animation was generated .theme-demo.mdc-checkbox--anim-unchecked-checked .... (without space after .theme-demo).

Two components mdc-top-app-bar and mdc-checkbox are affected by this problem.

Including whole components style inside parent selector is considered as a bad practice, so no fixes on components side required. Since this code already removed from material-components-web-catalog no additional actions required.

Closing this issue.

from material-components-web-catalog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.