Update `getWebCrypto()` for Node 20 about simplewebauthn HOT 2 CLOSED

A poll on Mastodon didn't help me choose between "change only a couple of files by keeping getWebCrypto() asynchronous" and "change a bunch of files by making getWebCrypto() synchronous because it doesn't need async anymore":

So I prepard two PRs:

• #533 makes getWebCrypto() synchronous because it no longer needs to await import('node:crypto'). This spiders out into the codebase because a lot of async methods that called await getWebCrypto() no longer need to be async, and refactoring all of these pleases deno lint. This includes making generateRegistrationOptions() and generateAuthenticationOptions() synchronous, which technically makes this a breaking change (though there's no repercussion for awaiting a synchronous function in JavaScript so it's not as breaking a change as going from synchronous to asynchronous.)
• #535 keeps getWebCrypto() asynchronous despite not needing to await anything. The scope of work is limited to getWebCrypto.ts and its corresponding getWebCrypt.test.ts.

Honestly I'm leaning towards #535 for what feels like an odd justification: not making generateRegistrationOptions() and generateAuthenticationOptions() synchronous means all four of the "core library API" methods (those two along with verifyRegistrationResponse() and verifyAuthenticationResponse()) remain asynchronous. Put another way, keeping getWebCrypto() asynchronous means there's no need to remember which core library methods need to be awaited or not because they all need to be await'd!

I'm gonna sleep on this for a few days and see what I settle on.

from simplewebauthn.

This change is now available in the recently-published @simplewebauthn/[email protected] ✌️

from simplewebauthn.