Giter Club home page Giter Club logo

Comments (6)

1aron avatar 1aron commented on May 12, 2024 1

@JacobLinCool Sorry for the confusion caused by the old documentation, I will explain all this later with the new documentation.

Our new documentation face will be updated soon. 🀩 Stay tuned.

from css.

JacobLinCool avatar JacobLinCool commented on May 12, 2024 1

@1aron Thanks for your response.

I understand the concepts behind the pre-generating strategy, but it seems not a good idea to use Master CSS variables within native CSS? Master CSS variables are more likely the internal (private) ones to me and should not be accessible by other parties.

If I have to share variables within and without Master CSS, maybe I would like to control the state by myself.

from css.

1aron avatar 1aron commented on May 12, 2024 1

@JacobLinCool This issue has been sorted into milestone. 😌 https://github.com/master-co/css/milestone/1

from css.

1aron avatar 1aron commented on May 12, 2024 1

@JacobLinCool I think we might go with your idea - the preset will map colors and inline the rgb into CSS rules, for a minimal output.

Thx again. 😌

from css.

1aron avatar 1aron commented on May 12, 2024

@JacobLinCool About the color tree shaking, let me explain first.
In the future we will have three modes:

  1. Map colors directly, inline rgb in CSS rules ( minimal output )
  2. Generate the CSS color variables according to the used colors
  3. Pre-generate all CSS color variables ( currently preset )

Why use CSS Variables for this? For now, most people still write CSS rules for some reason, so if you want to access the Master's colors, you must go through CSS variables.

from css.

1aron avatar 1aron commented on May 12, 2024

@JacobLinCool Agree, so there will be three modes for you to choose.

If you want to use Master Colors in CSS files and we didn't pre-generated CSS variables for you, you have to look up the color table and define the variables manually, which will reduce the development experience.

Other CSS frameworks don't do this, so people keep raising this issue.

from css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.