masoniteframework / cookie-cutter Goto Github PK

This file should be recreated with only Masonite 4 env variables, and maybe with a space to separate per config file.
Also some variable do not match variables used in some features.

In a "real-life" app, the user will likely need an AppProvider.

Either to register Gates, add tasks to schedule...

I propose that we add a default one in the project template.

The database config file contains the following code

"host": env("MSSQL_DATABASE_HOST"),
"user": env("MSSQL_DATABASE_USER"),
"password": env("MSSQL_DATABASE_PASSWORD"),
"database": env("MSSQL_DATABASE_DATABASE"),
"port": env("MSSQL_DATABASE_PORT"),

which is used to get the configuration for a MSSQL database connection. The naming of the environment variables is not consistent with the rest of the config file, which all use a DB_* scheme, nor are these variables defined/mentioned in the .env.example file.

Suggestion is to either add these variables to the example file, or probably preferable, change the code to match the rest of the scheme

It was available in M3
https://github.com/MasoniteFramework/masonite/blob/3.0/app/http/middleware/AuthenticationMiddleware.py

Someone was mentioning this: then we just have to run npm run dev and start serving the app...but what if assets are not compiled, there will be 404 for the assets on the default page...

@josephmancuso How Laravel is handling this ?

Also the default staticfiles bindings were found to be not coherent, like css resource is served at assets/css but not js, so maybe we have to fix this too.