Comments (6)
[...] you have to be a bit patient in guiding me. I already hit the "pull request" link at the top of the page (on the light blue bg, not at the absolute top with bg black), but didn't understand what to to then.
Hello. A pull request is more a:
- fork the original project into your own copy of the repo
- make modifications to the files of your copy of the repo
- commit and push the modification to your copy of the repo
- Pull Request the changes from your copy to the original repo
Maybe this guide can show some light: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
from pacman.
hello! thanks for finding this bug, want to submit a pull request with the fix?
from pacman.
Well, yes, in principle. I haven't done a pull request before, so maybe you have to be a bit patient in guiding me. I already hit the "pull request" link at the top of the page (on the light blue bg, not at the absolute top with bg black), but didn't understand what to to then.
from pacman.
I see. Don't you think this is too much effort for a 1 single character fix? I would prefer, if you do the fix yourself and don't need a mention in the logs or somewhere.
from pacman.
Wasn't able to replicate this, so closing for now.
from pacman.
I can reproduce on Ubuntu 20,04
/pacman$ sh build.sh
sed: -e expressió #1, caràcter 1: ordre desconeguda: «.»
$ sed --version
sed (GNU sed) 4.7
Packaged by Debian
As stated by Stefan, the issue is in https://github.com/masonicGIT/pacman/blob/master/build.sh#L87
sed -i '.bak'
as the space behind -i
is not recognized on Linux.
if changed by
sed --in-place='.bak' "s/last updated:[^<]*/last updated: $(date) -->/" index.html
does still work on your system @masonicGIT ?
from pacman.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pacman.