Comments (2)
@petermasking I have been looking where we can fix this, but I cannot find any place in the runtime. The RemoteBuilder in the caching
package seems to output the incorrect data for remote implementations.
// getEmployee.remote.js
export async function getEmployee(id) {
return __runProcedure('getEmployee', '1.0.0', { 'id': id }, this);
}
export async function getEmployeeV2(uuid) {
return __runProcedure('getEmployee', '1.0.0', { 'uuid': uuid }, this);
}
The local implementation is correct though.
// getEmployee.local.js
export async function getEmployee(id) {
return {
id: id,
name: 'John Doe',
age: 42,
};
}
export async function getEmployeeV2(uuid) {
return {
uuid: uuid,
name: 'John Doe',
age: 42,
address: '123 Main St.'
};
}
Shall we update the RemoteBuilder to keep track of each fqn and version it has already written for a single module?
from jitar.
We want to avoid finding these kind of issues at the runtime level, so check this while building the cache. Since it's a segment configuration error it should be detected when generating the segment cache model. The SegmentCacheBuilder
groups the procedures by FQN. At this stage we can detect if a version is registered twice and throw an error.
from jitar.
Related Issues (20)
- Fix returning non-string primitive types in the RPC API
- Change default source location for repository
- Protect private segment functions when called from the same node HOT 1
- Remove the need for the shared folder with Vite projects
- Prepare 0.4 release HOT 1
- Add BigInt serialization support
- Register custom serializers
- Auto generate changelog
- Add contribute and donate section to the website
- Clean up dependencies
- chore(deps): migrate to lerna 7
- bug(server): gateway serializes data, even when not requested
- Investigate OpenTelemetry integration
- Web core vitals
- Add sonarjs to eslint
- Update dependencies
- chore: release of 0.4.1
- Cors middleware does not get executed in standalone mode HOT 1
- Update dependencies HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jitar.