Giter Club home page Giter Club logo

Comments (2)

BasMasking avatar BasMasking commented on September 27, 2024

@petermasking I have been looking where we can fix this, but I cannot find any place in the runtime. The RemoteBuilder in the caching package seems to output the incorrect data for remote implementations.

// getEmployee.remote.js
export async function getEmployee(id) {
	return __runProcedure('getEmployee', '1.0.0', { 'id': id }, this);
}

export async function getEmployeeV2(uuid) {
	return __runProcedure('getEmployee', '1.0.0', { 'uuid': uuid }, this);
}

The local implementation is correct though.

// getEmployee.local.js
export async function getEmployee(id) {
    return {
        id: id,
        name: 'John Doe',
        age: 42,
    };
}
export async function getEmployeeV2(uuid) {
    return {
        uuid: uuid,
        name: 'John Doe',
        age: 42,
        address: '123 Main St.'
    };
}

Shall we update the RemoteBuilder to keep track of each fqn and version it has already written for a single module?

from jitar.

petermasking avatar petermasking commented on September 27, 2024

We want to avoid finding these kind of issues at the runtime level, so check this while building the cache. Since it's a segment configuration error it should be detected when generating the segment cache model. The SegmentCacheBuilder groups the procedures by FQN. At this stage we can detect if a version is registered twice and throw an error.

from jitar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.