Modification for jade about i18n-node HOT 9 CLOSED

Could you test if this is fixed in current Release? Req.locale now gets set in i18n.init too.

from i18n-node.

As I'm using it, still does not work.
I removed the manual response method registration for changes included in this 0.4.0 version.

For getting it to work as I excpected I need to comment the line 138 of the i18n.js:

request.locale = target_locale;

In my Jade templates I'm translating like this (I think that registered functions on responses made this method request-scoped):

#{__('locale.entry')}

On the other hand I've also noticed that in this version I need to configure i18n with './locales' directory, because it doesn't work by default.

from i18n-node.

this is wired. could you gist a sample of your complete implementation? There must be a reason why target_locale can't be filled as intended.

from i18n-node.

Marcus, I've prepared a little example but I cannot attach zip files here so there is a gist here with main files (created with express -s command and with i18n added): https://gist.github.com/nicosommi/a513bf2d1feea10794bd

The problem is that jade template is taking the locale from the response. In the example is registered global and changed globally, and accessing it by i18n.__ method uses globally setted locale, but templates still uses response locale that is guessed from the request. Maybe listening for locale changes and updating the response registered __ method can solve this use case.
For getting it to work as I did, you need to get your browser in spanish (es), and you will see that the template function is using 'es' even when i18n.__ is using 'en'.

Besides of that, in lines 18 and 35 of app.js I've commented other two minor issues.

from i18n-node.

Thanks I'll review your example shortly. Please note that you shouldn't register globally when using express & template. The intended use is for cli skripting only.

Let me track down your issue via gist

from i18n-node.

Yes you are correct about CLI script. It's specified in the README. What I need to do is to let the user choose the application language despite of the browser's language.

from i18n-node.

this should work in your indes.js:

exports.index = function(req, res){
  res.setLocale('en');
  res.render('index', {globaltitle: res.__('title')});
}

from i18n-node.

Marcus thanks for that tip. Combining what you say and adding cookie support I can reach my goal.

The change language methods looks finally like this (supossing that is on the index function):

exports.index = function(req, res){
  res.setLocale('en'); //for current request
  res.cookie('userlang', 'en'); //for future request of that user
  res.render('index', {globaltitle: res.__('title')});
};

And the configuration must have cookie:

i18n.configure({
    locales: ["en", "es"],
    defaultLocale: "en",
    directory: "./locales",
    extension: "js",
    cookie: 'userlang',
    debug: true
});

...
app.use(express.cookieParser());
...

from i18n-node.

Excellent! Glad to have helped you - I'll collect some more examples to get that clear for future docs :)

from i18n-node.