Giter Club home page Giter Club logo

Comments (4)

KarolosLykos avatar KarolosLykos commented on June 2, 2024 1

Hey @MarvinJWendt , I ran some benchmarks and rand.Shuffle is faster. Look at the benchmark tests and tell me what you think? benchmarks

I also included a PR with the proposal.

from testza.

KarolosLykos avatar KarolosLykos commented on June 2, 2024

Hi @MarvinJWendt I was thinking of trying this one what do you think of something like that.

func FuzzUtilLimit[setType any](testSet []setType, limit int) []setType {
	seen := map[int]bool{}

	if len(testSet) <= limit {
		return testSet
	}

	if limit <= 0 {
		return []setType{}
	}

	var result []setType

	counter := 0

	for counter < limit {
		index := rand.Intn(len(testSet) - 1)
		if !seen[index] {
			seen[index] = true
			result = append(result, testSet[index])
			counter++
		}

	}

	return result
}

from testza.

MarvinJWendt avatar MarvinJWendt commented on June 2, 2024

Hi @KarolosLykos, this would definitely work, but I am not sure if the performance might be better with rand.Shuffle. We could then return a sub-slice of the shuffled slice (shuffledTestSet[:limit]). If you want to benchmark both approaches, feel free to do so, otherwise I'll do it in the next weeks and get back to you with the result :)

from testza.

MarvinJWendt avatar MarvinJWendt commented on June 2, 2024

Fixed in #200 and released with v0.5.2. Thanks!

from testza.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.