Giter Club home page Giter Club logo

Comments (2)

marty-oehme avatar marty-oehme commented on June 2, 2024 1

We are now getting the emoji from the new url on download on the dev branch.

I have decided against moving the url variables to the top to make them less magical - each of the download routines itself is closely tied to the content at their respective links and it does not make too much sense to allow to change them.
Such a change should instead take place when (if) we extract the download functionality itself to make it less hard-coded than it currently is.

from bemoji.

marty-oehme avatar marty-oehme commented on June 2, 2024

Thanks for the report, that is really good input!

I do not remember why I chose the hard-coded '14.0' emoji download link but we can definitely use https://unicode.org/Public/emoji/latest/emoji-test.txt instead to always grab the latest.

And I think it is also a good point to extract the magic URL values somewhere to the top. I am still considering moving the whole downloading portion into a separate executable but this is a good first step to remove some 'magic' from it.

I'll definitely get around to the changes but am also happy to merge a little PR if you're inclined!

from bemoji.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.