Giter Club home page Giter Club logo

Comments (2)

ergoithz avatar ergoithz commented on June 16, 2024

I don't think this is a bad suggestion, you can always use a lambda mapping to turn your O(n) if-elif-else into a O(1) operation.

def example(action, **kwargs):
    def default(**_):
        return None

    actions = {
        'launch': lambda **_: launch('Rockets'),
        'pet': lambda *, animal: pet(animal),
        'idle': lambda **_: None,
    }

    return actions.get(action, default)(**kwargs)

You can even omit the intermediate lambdas if you prepare your functions for this usage.

Alternatively, I tend to suggest a getattr approach (__dict__ lookup) for the most complex scenarios:

class case:
    @classmethod
    def handle_launch(cls, **_):
        return launch('Rockets')

    @classmethod
    def handle_pet(cls, *, animal):
        return pet(animal)
    
    @classmethod
    def handle_idle(cls, **_):
        return None

    @classmethod
    def handle_default(cls, **_):
        return None

    @classmethod
    def handle(cls, action, **kwargs):
        return getattr(cls, f'handle_{action}', cls.handle_default)(**kwargs)

The above are quite common patterns used on parsers.

This of course would be no longer necessary with Python 3.10 match/case (PEP634).

from flake8-simplify.

MartinThoma avatar MartinThoma commented on June 16, 2024

I think the mentioned issue with SIM116 was fixed in the context of #113 . I'll make a release with that fix today.

from flake8-simplify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.