Color changed listener about hsv-alpha-color-picker-android HOT 8 CLOSED

I'd happily consider a pull request.

from hsv-alpha-color-picker-android.

Done

from hsv-alpha-color-picker-android.

Thanks for the quick work. I'll have a proper look later. One issue: the removeColorObserver function doesn't do what it says. In practice maybe we could live without that function anyway.

Also, what's the rationale for putting IColorObserver into it's own package? It creates a need for explicit imports everywhere for no real benefit that I can see.

from hsv-alpha-color-picker-android.

I'll remove the removeColorObserver, I personally don't need it. Just wanted it to be there for the case...

And I'll make the listener an internal class again...

I personally prefer code like:

.addListener(new IColorChangedListener(){...})

Over colde like:

.addListener(new BaseClass.IColorChangedListener(){...})

It's cleaner IMHO... I personally use internal listeners only if they are private or protected...

from hsv-alpha-color-picker-android.

I meant the com.rarepebble.colorpicker.interfaces package (as opposed to just putting it in com.rarepebble.colorpicker). Putting it in a separate module seems reasonable.

from hsv-alpha-color-picker-android.

I see... Misunderstood you.

It's just because I'm used to it... To group and organize my classes...

In a little library like this it's probably not necessary...

from hsv-alpha-color-picker-android.

I corrected the code...

from hsv-alpha-color-picker-android.

All merged now, and built and published to jcenter as version 1.7.0.

Thanks!

from hsv-alpha-color-picker-android.