Wrong filepath posted to bucket about arc_gcs HOT 2 CLOSED

After testing, I think I found part of the problem.
Something is wrong by the use of Arc.Definition.Versioning.resolve_file_name(definition, version, file_and_scope) over here

By the time this function is called, the Arc.File looks something like the following:

%Arc.File{
   binary: nil,
   file_name: "1_list_image.jpg",
   path: "/var/folders/7n/l6vc139d0c7bswg8b84j45s80000gn/T/QEWTHIDYJLEA2IDVIQXGVLPAB5EUWCWU.png"
 }

Note how file_name already has the format that the definition has defined. Then when we call Arc.Definition.Versioning.resolve_file_name, we are essentially running through the definition's filename function again resulting in a redundant operation. I'm not sure what the intention is and would love some feedback. In the meantime, I'll continue to work on a fix.

from arc_gcs.

I found the bug and have a pull request finished.

The issue is that the file path must be calculated separately in the put function as arc has already modified the file.file_name value to reflect the output of the definition's filename function.

Therefore, we can't use do_gcs_key at this point in time.

I made some changes that take the same approach as arc's S3 layer - namely, calculate path during the put function.

from arc_gcs.