Client reconnect on CBORDecodingError creating infinite loop reading frames about atproto HOT 12 CLOSED

Looks like it's working, thank you!

from atproto.

@joelghill let me know if you can install this dev build with the new WS lib to your feed and run it for a few hours. Nothing changed for public API. Only my internals of firehose client impl

atproto-0.0.20.dev3.tar.gz

from atproto.

I'll take a look sometime this evening!

from atproto.

Still playing around with it on my end, but so far I haven't seen any exceptions and it's spinning up far fewer threads in the background. Seems much more stable!

from atproto.

Also , the fan on my laptop is much quieter, so that's also a good sign, haha!

from atproto.

Thank you for your tests! I'll include this PR in the next release

from atproto.

What a good catch! Thank you! Yeah, it requires deep research into CBOR decoding that is provided by 3d part lib, but for now, let's ignore frames that could not be decoded. The fix will be included in the next release (v0.0.19)

from atproto.

@joelghill released. pls verify pip install -U atproto

from atproto.

all issues are coming from a library that I chose as WS client... i migrated to stable one and all issues are gone! #101 i'll merge it soon

from atproto.

I also expect that it manages threads much better. But I didn't notice a big performance boost or something like that. That's cool that now we can peacefully decode cbor without frame looses

from atproto.

I stay connected to the firehose for 7 hours without any errors. Looks soo stable

from atproto.

released in v0.0.20

from atproto.