Giter Club home page Giter Club logo

Comments (1)

yhatt avatar yhatt commented on August 17, 2024

Marp CLI has historically been fail fast to avoid passing conversion errors to subsequent processes, such as watch mode, preview mode, etc.

marp-cli/src/marp-cli.ts

Lines 358 to 372 in 04a1bcf

try {
if (cvtOpts.server) {
await converter.convertFiles(foundFiles, { onlyScanning: true })
} else {
cli.info(`Converting ${length} markdown${length > 1 ? 's' : ''}...`)
await converter.convertFiles(foundFiles, { onConverted })
}
} catch (e: unknown) {
if (isError(e)) {
const errorCode = e instanceof CLIError ? e.errorCode : undefined
error(`Failed converting Markdown. (${e.message})`, errorCode)
} else {
throw e
}
}

If we were to refactor the multi-file conversion, we would have to make the error scope file by file, and then pass the conversion success/failure for each file to the subsequent process. :)

It would be good to provide --fail-fast option too, for users who want the traditional workflow.

from marp-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.