marmat / google-maps-api-addons Goto Github PK

Hello,

First, I want to say that this add on is excellent. However, I'm seeing an issue when trying to place markers based on a specific pano.

I am making a custom tour, and when the heading and pitch are 0, it seems to work alright, but when I change the heading i'm seeing the issue.

It might be helpful to say that if you click on one of the markers within the minimap is what triggers the error, or when you navigate inside of the facility.

It seems like the offset is undefined for some reason but I haven't been able to trace it down. It seems to fail a sanity check between 193 and 202.

I figured I would reach out to see if you might be able to offer any advice on this issue. Thanks so much!

Just a reminder for me to fix this issue.

Hi, I was searching for it, let me say thanks for share it...nice one.

I am able to create the overlay but I would like create a link to remove it...

Let me say the final job will be:
a link where I can create or remove it

thanks in advance

Hello
I'm trying to get a marker and his left and top position after creating
but PanoMarker returns an empty marker_
See http://jsfiddle.net/en8tgqaz/

While applying the value for this.povToPixel_ using window.chrome check, fails on Firefox.

/* Currently only Chrome is rendering panoramas in a 3D sphere. The other
 browsers are just showing the raw panorama tiles and pan them around.
 */

This scenario is no longer valid.

To fix it comment this line

// this.povToPixel_ = !!window.chrome ? PanoMarker.povToPixel3d : PanoMarker.povToPixel2d;

And add this code below it

this.povToPixel_ = PanoMarker.povToPixel2d;
var pixelCanvas = document.createElement("canvas");

  
if (pixelCanvas && (pixelCanvas.getContext("experimental-webgl") || pixelCanvas.getContext("webgl"))) 
{
   this.povToPixel_ = PanoMarker.povToPixel3d;
}

Just a reminder for me to fix this issue.

Hello from 2022! Just discovered this beauty and it's been wonderful. I've a question - how do we fix the position of the pano marker when user moves around (not pov change or zoom, but for example, click to go around). i.e. something like:

• http://projects.teammaps.com/projects/streetviewoverlay/streetviewoverlay.htm
• Or the default marker which sticks to its position via lat/ long.

Here's hoping miracle can happen!

Hi there,

First of all, this addon is simply amazing, thank you for that.
Then... :) Do you know if there's an equivalent "panTo" method but for panoramas? I don't think so. My challenge is to replicate the smooth panTo animation. A kind of panToPov instead of a brutal setPov ;)
I ask myself if you never tried to do that too?

Anyway, great job!

Hi,

I'd like to be able to get the marker HTML so I'm able to add an event listener and also get the position of it. Unfortunately, this.marker_ is created from the onAdd method which isn't evaluated immediately after the constructor is called. Would it be possible to add a callback from onAdd? Maybe a callback could be defined in the options?

If you agree with this approach, I'd be happy to arrange a pull request.

Thanks!

In Safari (9.1, OS X El Capitan) the panomarker anchoring seems to be off when panning around. The marker moves around a bit. This is in Street View WebGL mode (as no other mode seems to work currently in Safari). In Chrome there is no issue, the marker moves as it should.

Hello, very cool plugin.
But how to add InfoWindow? Is it possible to use the positioning marker for InfoWindow from google or easier to use custom infobox?

Are there any plans to improve PanoMarker?
Would be good to have draggable PanoMarker (same as in Google marker)

With javascript there is an undocumented option: "mode" which improves a lot the render mode with these 3 modes:

• 'html4': Street View tiles are rendered as HTML tags without warping.
• 'html5': Street View tiles are rendered using Canvas 2D.
• 'webgl': Street View tiles are rendered using WebGL (aka Canvas 3D).

Can you please add in your dart lib version too?
For more details: https://productforums.google.com/forum/#!msg/maps/D-zAB9gwS7k/9m1QZ0L2cqUJ

...probably because it's the reference point of our calculations. I guess there's some sign error or something, have to look at it later.

I created a test case and SimpleMarker performance is poor.

Can you check whether the test is correct?

http://jsperf.com/google-maps-marker-vs-simplymarker

First I want to congratulate you for this excellent library called panomarker.js.

I just want know, why I can not create several panomarkers in the same panorama ?

is a restriction in the library ? or a bug ?

here an example I want to add more than one marker: https://jsfiddle.net/sn8L7u0r/3/ , just click on the button to add several markers

I am working in an project where I need add several of these.

Thanks.

Just a reminder for me to fix this issue.

Help me

Hi :)

I was wondering if would be possible to develop a way to use custom html as markers instead image only.

I'm about to test a solution like creating all necessary markers using PanoMarker, then appending custom html markers inside the panorama div container.

Basically I could track the position of each pano marker using pov_changed event, applying those values to my custom divs that would follow the same position of PanoMarkers inside the panorama.

There is any other way to do it?

Thank you.

More a feature request, but when setting the pano for a PanoMarker, a Promise would allow the user to know when the PanoMarker has been added to the DOM and can be manipulated.

Here is my implementation using native Promises:

PanoMarker.prototype.setPano = function(pano) {
    // In contrast to regular OverlayViews, we are disallowing the usage on
    // regular maps
    if (!!pano && !(pano instanceof google.maps.StreetViewPanorama)) {
        throw 'PanoMarker only works inside a StreetViewPanorama.';
    }

    // Remove the marker if it previously was on a panorama
    if (!!this.pano_) {
        this.onRemove();
    }

    // Call method from superclass
    this.setMap(pano);
    this.pano_ = pano;

    // Fire the onAdd Event manually as soon as the pano is ready
    if (!!pano) {
        if (!!this.getPanes()) {
            return new Promise(function (resolve) {
                this.onAdd();
                resolve(this);
            }.bind(this));
        } else {
            return new Promise(function (resolve) {

                // Poll for panes to become available
                var pollCallback = function() {
                    if (!!this.getPanes()) {
                        window.clearInterval(this.pollId_);
                        this.onAdd();
                        resolve(this);
                    }
                };

                this.pollId_ = window.setInterval(pollCallback.bind(this), 10);
            }.bind(this));
        }
    }
}

While this worked for my use case, using native Promises completely eliminates IE support (even IE11 doesn't have native Promises). Therefore, we'd need to introduce an external Promise library like bluebird for cross-browser compatibility.

Just a reminder for me to fix this issue.

Just a reminder for me to fix this issue.

panoMarker on Chrome remains on the very same correct place.
when tried to move panorama on Firefox ESR 45.7.0 (Your sample with bicycle), info icon moves away from the seat.

Just a reminder for me to fix this issue.