Giter Club home page Giter Club logo

Comments (3)

markets avatar markets commented on June 6, 2024

Yep, that also happened to me a couple of times, at this point I18n.available_locales, got a lot of locales coming from other gems. I think this should be "fixed" by:

Maily.setup do |config|
  config.available_locales = Rails.application.config.i18n.available_locales
  ...
end

Maybe this would be a better default in general:

diff --git a/lib/maily.rb b/lib/maily.rb
index f43fbf2..352e460 100644
--- a/lib/maily.rb
+++ b/lib/maily.rb
@@ -13,7 +13,7 @@ module Maily
       self.enabled            = Rails.env.production? ? false : true
       self.allow_edition      = Rails.env.production? ? false : true
       self.allow_delivery     = Rails.env.production? ? false : true
-      self.available_locales  = I18n.available_locales
+      self.available_locales  = Rails.application.config.i18n.available_locales || I18n.available_locales
       self.base_controller    = 'ActionController::Base'
       self.http_authorization = nil
       self.hooks_path         = "lib/maily_hooks.rb"

from maily.

markets avatar markets commented on June 6, 2024

hi @pablocrivella I finally pushed a change to improve Maily defaults: be46fa5 🎉

from maily.

pcriv avatar pcriv commented on June 6, 2024

Nice! 💯

from maily.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.