First, thank you for these packages! The default values for each fun

Default Parameter Values being NULL breaks API calls about autogoogleapi HOT 3 CLOSED

markedmondson1234 commented on June 13, 2024

Default Parameter Values being NULL breaks API calls

from autogoogleapi.

Comments (3)

MarkEdmondson1234 commented on June 13, 2024

Yes this is a bug I haven't documented yet.

I fix this by using a helper function that removes all NULL from a list, and pass that instead.

Here is my fix I used in a project recently.

I have two helper functions to help with NULLs:

#' A helper function that tests whether an object is either NULL _or_
#' a list of NULLs
#'
#' @keywords internal
is.NullOb <- function(x) is.null(x) | all(sapply(x, is.null))

#' Recursively step down into list, removing all such objects
#'
#' @keywords internal
rmNullObs <- function(x) {
  x <- Filter(Negate(is.NullOb), x)
  lapply(x, function(x) if (is.list(x)) rmNullObs(x) else x)
}

Then I use that like in this function for googleComputeEngineR:

  url <- sprintf("https://www.googleapis.com/compute/v1/projects/%s/aggregated/machineTypes", 
                 project)
  
  pars <- list(filter = filter, 
               maxResults = maxResults, 
               pageToken = pageToken)

## remove NULL obs as it breaks the API call
  pars <- rmNullObs(pars)

  # compute.machineTypes.aggregatedList
  f <- gar_api_generator(url, 
                         "GET", 
                         pars_args = pars, 
                         data_parse_function = function(x) x)
  f()

I will add this fix to googleAuthR and regenerate these libraries soon. Also be aware of another bug I found, the order of the parameters passed into the API can be in the wrong order. ( #2 )

from autogoogleapi.