Giter Club home page Giter Club logo

Comments (5)

chaosarium avatar chaosarium commented on August 14, 2024 1

I'm suspecting that the react-18-autoresize-input has broken something internally. Can you take a look into this package?

sure

from c0vm-ts.

chaosarium avatar chaosarium commented on August 14, 2024

Interesting. Seems to work fine on the tab-rename-fix branch and on commit c7f9311. Could it have been an issue with 88e5e64?

from c0vm-ts.

MarkChenYutian avatar MarkChenYutian commented on August 14, 2024

I'm suspecting that the react-18-autoresize-input has broken something internally. Can you take a look into this package?

from c0vm-ts.

chaosarium avatar chaosarium commented on August 14, 2024

Just logging investigation progress.

Switching back to react-autoresize-input doesn't make the issue go away.

It seems like that, after loading file, EditableTab's props.title is updated but state.title is not.

from c0vm-ts.

chaosarium avatar chaosarium commented on August 14, 2024

@MarkChenYutian was there a change to how set_tab_name works? I don't know if changing this.props.setTabName to this.set_tab_name affected React's state update.

Anyhow, a fix is on the way. It checks if EditableTab should get updated and updates accordingly.

from c0vm-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.