Giter Club home page Giter Club logo

Comments (4)

gavinaiken avatar gavinaiken commented on July 28, 2024 1

Yes that is absolutely fine because session is actually declared at the top of your meander due to "hoisting". https://www.w3schools.com/js/js_hoisting.asp
It isn't initialized until the var session = setupV3Session line, but since that runs before the session.close line in the meanderDoneCB executes that is also fine.

from node-net-snmp.

gavinaiken avatar gavinaiken commented on July 28, 2024

Yes, the done callback is a good place to call session.close(). You want to make sure you always do it, regardless of errors.

from node-net-snmp.

JasMetzger avatar JasMetzger commented on July 28, 2024

Thank you--I thought so.

In this function I call meander, the session.close() happens in the done callback. But the session object is not passed into the callback. Since this is a promise, I think it's ok to use session still.

function meander(bindaddress, hostaddress, hostport, username, authtypestr, authpass, privtypestr, privpass, contextname, contextengine, oneoid)
{
return new Promise((resolve, reject) => {

    function meanderDoneCB (error) 
    {
        if (error)
            reject(error.toString ());

        // done witout error
        resolve();

        session.close();
    }

    function meanderFeedCB (varbinds) 
    {
        for (var i = 0; i < varbinds.length; i++) 
        {
            if (snmp.isVarbindError (varbinds[i]))
            {
                reject(snmp.varbindError(varbinds[i]));
            }
            else
            {
                switch (varbinds[i].type) 
                {
                    case snmp.ObjectType.Boolean:
                         // value is a boolean
                        console.log(`${String(varbinds[i].oid)}: ${varbinds[i].value.toString()} (Boolean)`);
                        break;
                  ...
                }
            } 
        }          
    }

    var session = setupV3Session(bindaddress, hostaddress, hostport, username, authtypestr, authpass, privtypestr, privpass, contextname, contextengine);

    var maxRepetitions = 20;
    session.walk(oneoid, maxRepetitions, meanderFeedCB, meanderDoneCB);
});

}

from node-net-snmp.

JasMetzger avatar JasMetzger commented on July 28, 2024

Thank you!

from node-net-snmp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.