Giter Club home page Giter Club logo

Comments (7)

MarcoMeter avatar MarcoMeter commented on August 25, 2024 1

Hi @npitsillos
the data is fed to the recurrent layer like you said (10, 128, state_dim). The result of the recurrent layer is reshaped to (10 * 128, state_dim). Basically the remaining layers of the model treat each item of the sequence individually. So does the loss, except that padded items are masked. The only component that does utilize 3 dimensions, is the recurrent layer. For the loss and everything else it is just 2 dimensions.

Is this helpful to you?

from nerorl.

MarcoMeter avatar MarcoMeter commented on August 25, 2024 1

You can also check out my baseline implementation, which isolates the recurrent PPO setup as much as possible.
https://github.com/MarcoMeter/recurrent-ppo-truncated-bptt

from nerorl.

npitsillos avatar npitsillos commented on August 25, 2024

Yes this is helpful! And also I was referencing that repo before in the issue the code was the same and I got confused as to which repo I should use. One final thing the idea behind the masks is to mask out those timesteps that have been padded with 0s?

Thank you again for your help!

from nerorl.

npitsillos avatar npitsillos commented on August 25, 2024

As a final example the mask is supposed to be of the same dimensionality (10,128) to select those values for the loss

from nerorl.

MarcoMeter avatar MarcoMeter commented on August 25, 2024

Yes, you are right. The mask masks out time steps that were added due to zero padding.
The masks' shape is (10*128). As it is not part of the forward pass of the model it does not need to be in the shape of (sequence length, num sequences.

from nerorl.

npitsillos avatar npitsillos commented on August 25, 2024

Thank you very much for the explanation! This has helped me a lot in implementing my own repo!

from nerorl.

MarcoMeter avatar MarcoMeter commented on August 25, 2024

No problem, you are welcome!

from nerorl.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.