Giter Club home page Giter Club logo

Comments (1)

MarcKaufmann avatar MarcKaufmann commented on July 21, 2024

Nice, especially that it works for all users. However, we now need a way to stop impersonating that user and return to normal admin mode, hence I reopen the issue. Looking at the code, it seems like you are setting the id of the session-cookie to that of the person being impersonated, in which case that won't allow jumping back to admin afterwards. Currently, getting back to admin requires logging out after impersonating and then logging in again as admin. Is that single direction intended? It would be nice to have a smoother way to get back to admin.

Maybe if session-key was a list, with the head used as session-key, and only admins can add to the front of session-keys by impersonating? Then one can go back to admin by dropping the head. session-key is probably too general, so session-impersonator-key as the key of the original impersonator might work.

Another issue: it doesn't seem right to allow admins to impersonate other admins -- or can you imagine a use case? I am worried that one admin can take actions for another, and it is impossible to tell the two apart.

from congame.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.