Comments (1)
Nice, especially that it works for all users. However, we now need a way to stop impersonating that user and return to normal admin mode, hence I reopen the issue. Looking at the code, it seems like you are setting the id of the session-cookie to that of the person being impersonated, in which case that won't allow jumping back to admin afterwards. Currently, getting back to admin requires logging out after impersonating and then logging in again as admin. Is that single direction intended? It would be nice to have a smoother way to get back to admin.
Maybe if session-key
was a list, with the head used as session-key
, and only admins can add to the front of session-keys
by impersonating? Then one can go back to admin by dropping the head. session-key
is probably too general, so session-impersonator-key
as the key of the original impersonator might work.
Another issue: it doesn't seem right to allow admins to impersonate other admins -- or can you imagine a use case? I am worried that one admin can take actions for another, and it is impossible to tell the two apart.
from congame.
Related Issues (20)
- Why does `->jsexpr` make the load time faster when displaying files on admin? HOT 1
- koyo reloading issue HOT 3
- Long load time after lobby? DB issue? HOT 2
- Improve error message/blame when `make-step` used incorrectly
- redirect loop when enrolling from identity and first step has `skip` HOT 2
- email messages to identity need to be implemented HOT 1
- Add enrollment code to signup on congame (not identity) servers HOT 1
- `user-manager-verify` contract error HOT 1
- Study instances are launched based on name instead of id and thus have to be unique HOT 1
- get `identity-url` from DB when sending emails to identity users HOT 1
- congame-web/components/identity breaks the build
- Postgres `remaining connection slots are reserved for non-replication superuser connections` HOT 1
- Checking enrollment code: why do we need to drop the protected continuation? HOT 1
- PDF `save-file!` fails for one pdf file HOT 8
- How to get rid of the 'session expired' error at the top? HOT 1
- Impersonate does not work anymore HOT 1
- sub-study does not seem to put the `required` value HOT 5
- New package fails to compile but succeeds after changing file
- `formular` as final page of study seems not to work
- dashboard takes 50 seconds to load on login
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from congame.