Giter Club home page Giter Club logo

Comments (3)

MarcJHuber avatar MarcJHuber commented on July 17, 2024

Fixed, thanks!

from event-driven-servers.

gregoo avatar gregoo commented on July 17, 2024

FYI this does not fix PAM in security/ if configure is ran with --with-pam. At line 735, WITH_PAM is already not empty and thus it does not enter the block containing the check for security/.

/event-driven-servers # ./configure --with-pam tac_plus-ng

/event-driven-servers # grep PAM build/Makefile.inc.linux-5.15.0-39-generic-x86_64
WITH_PAM=1
LIBDIR_PAM=/usr/lib
INCDIR_PAM=/usr/include

/event-driven-servers # make
[...]
cc  -Wall -W -Wno-strict-prototypes -Wno-implicit-fallthrough   -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DOSTYPE=linux -DOSLEVEL=0x00000000 -DOS="\"linux-5.15.0-39-generic-x86_64\"" -DWITH_EPOLL -DWITH_POLL -DWITH_SELECT -DWITH_IPC -I/event-driven-servers       -I/usr/include -c -o pammavis.o /event-driven-servers/mavis/pammavis.c
In file included from /event-driven-servers/mavis/mavis.h:17,
                 from /event-driven-servers/mavis/pammavis.c:9:
/usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
    1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
      |  ^~~~~~~
/event-driven-servers/mavis/pammavis.c:20:10: fatal error: pam/pam_appl.h: No such file or directory
   20 | #include <pam/pam_appl.h>
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [/event-driven-servers/Makefile.inc:879: pammavis.o] Error 1
make[2]: Leaving directory '/event-driven-servers/build/linux-5.15.0-39-generic-x86_64/mavis'
make[1]: *** [GNUmakefile:21: build] Error 2
make[1]: Leaving directory '/event-driven-servers/mavis'
make: *** [GNUmakefile:31: dirs] Error 1

I feel like you kind of need to duplicate the check, once with an empty WITH_PAM and once with a WITH_PAM=1.

from event-driven-servers.

gregoo avatar gregoo commented on July 17, 2024

Looks good on Alpine now

/event-driven-servers # ./configure tac_plus-ng
/event-driven-servers # grep PAM build/Makefile.inc.linux-5.15.0-39-generic-x86_64
/event-driven-servers # make 2>&1 | grep pam
cc  -Wall -W -Wno-strict-prototypes -Wno-implicit-fallthrough   -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DOSTYPE=linux -DOSLEVEL=0x00000000 -DOS="\"linux-5.15.0-39-generic-x86_64\"" -DHAVE_SECURITY_PAM_APPL_H -DWITH_EPOLL -DWITH_POLL -DWITH_SELECT -DWITH_IPC -I/event-driven-servers        -c -o pammavis.o /event-driven-servers/mavis/pammavis.c
                 from /event-driven-servers/mavis/pammavis.c:9:
cc -o pammavis pammavis.o '-Wl,-rpath,$ORIGIN/../lib' "-L/event-driven-servers/build/linux-5.15.0-39-generic-x86_64/mavis" "-Wl,-rpath,/usr/local/lib" -lmavis  -lpam
cc  -Wall -W -Wno-strict-prototypes -Wno-implicit-fallthrough   -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DOSTYPE=linux -DOSLEVEL=0x00000000 -DOS="\"linux-5.15.0-39-generic-x86_64\"" -DHAVE_SECURITY_PAM_APPL_H -DWITH_EPOLL -DWITH_POLL -DWITH_SELECT -DWITH_IPC -I/event-driven-servers       -fPIC  -c -o libmavis_pam.o /event-driven-servers/mavis/libmavis_pam.c
                 from /event-driven-servers/mavis/libmavis_pam.c:40:
cc -shared -o libmavis_pam.so libmavis_pam.o -lpam
install -c -m 0755 libmavis_pam.so /event-driven-servers/build/linux-5.15.0-39-generic-x86_64/fakeroot/usr/local/lib/mavis/libmavis_pam.so
install -c -m 0755 pammavis /event-driven-servers/build/linux-5.15.0-39-generic-x86_64/fakeroot/usr/local/sbin/pammavis
/event-driven-servers # ./configure --with-pam tac_plus-ng
/event-driven-servers # grep PAM build/Makefile.inc.linux-5.15.0-39-generic-x86_64
WITH_PAM=1
LIBDIR_PAM=/usr/lib
INCDIR_PAM=/usr/include
/event-driven-servers # make 2>&1 | grep pam
cc  -Wall -W -Wno-strict-prototypes -Wno-implicit-fallthrough   -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DOSTYPE=linux -DOSLEVEL=0x00000000 -DOS="\"linux-5.15.0-39-generic-x86_64\"" -DHAVE_SECURITY_PAM_APPL_H -DWITH_EPOLL -DWITH_POLL -DWITH_SELECT -DWITH_IPC -I/event-driven-servers       -I/usr/include -c -o pammavis.o /event-driven-servers/mavis/pammavis.c
                 from /event-driven-servers/mavis/pammavis.c:9:
cc -o pammavis pammavis.o '-Wl,-rpath,$ORIGIN/../lib' "-L/event-driven-servers/build/linux-5.15.0-39-generic-x86_64/mavis" "-Wl,-rpath,/usr/local/lib" -lmavis  -L/usr/lib -Wl,-rpath,/usr/lib -lpam
cc  -Wall -W -Wno-strict-prototypes -Wno-implicit-fallthrough   -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DOSTYPE=linux -DOSLEVEL=0x00000000 -DOS="\"linux-5.15.0-39-generic-x86_64\"" -DHAVE_SECURITY_PAM_APPL_H -DWITH_EPOLL -DWITH_POLL -DWITH_SELECT -DWITH_IPC -I/event-driven-servers       -fPIC -I/usr/include -c -o libmavis_pam.o /event-driven-servers/mavis/libmavis_pam.c
                 from /event-driven-servers/mavis/libmavis_pam.c:40:
cc -shared -o libmavis_pam.so libmavis_pam.o -L/usr/lib -Wl,-rpath,/usr/lib -lpam
install -c -m 0755 libmavis_pam.so /event-driven-servers/build/linux-5.15.0-39-generic-x86_64/fakeroot/usr/local/lib/mavis/libmavis_pam.so
install -c -m 0755 pammavis /event-driven-servers/build/linux-5.15.0-39-generic-x86_64/fakeroot/usr/local/sbin/pammavis
/event-driven-servers # ./configure --without-pam tac_plus-ng
/event-driven-servers # grep PAM build/Makefile.inc.linux-5.15.0-39-generic-x86_64
WITH_PAM=0
/event-driven-servers # make 2>&1 | grep pam
/event-driven-servers #

from event-driven-servers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.