Logged setting do not match those explicitly set in the example code about bme680 HOT 5 CLOSED

The function doesn't retrieve the temperature offset from the sensor, therefore it is set to none ( see function description of the get_sensor_settings e.g. here )

So it might be a bit confusing but it is the currently expected result. 🤔

from bme680.

@nickbroon good point, I see why this is confusing. As @caemor stated this is kind of expected since this temperature offset configuration is not stored in the sensor.
Here are some options I see:

1. return the value from `self.tph_sett.temperature_offset, which hides that it does not come from the sensor
2. not store it in the TphSett struct but separately to distinguish it
3. add better comments to TphSett.temperature_offset

I favor 1. or 2. but can not decide if it's really relevant to distinguish if this value comes from the sensor or not. What do you both think ? More ideas are welcome =).

from bme680.

I think 1 would be preferable, as I don't think there is need to distinguish what is stored in the hardware and what is stored in the driver. I tend to think of the driver and hardware as one unit from an api perspective.

from bme680.

I agree with nick that 1 would be the best from a user view

from bme680.

Fixed by 0c90c96 and released on 0.4.2

from bme680.