Giter Club home page Giter Club logo

Comments (4)

sbrunner avatar sbrunner commented on June 19, 2024

Is it OK If when the version is specified in the 'customParams' we use the provided value ?

from mapfish-print.

fvanderbiest avatar fvanderbiest commented on June 19, 2024

probably, yes

from mapfish-print.

fvanderbiest avatar fvanderbiest commented on June 19, 2024

I might change my mind. Indeed, the version parameter is part of the WMS layer's DEFAULT_PARAMS in OpenLayers.Layer.WMS prototype, see https://github.com/openlayers/openlayers/blob/master/lib/OpenLayers/Layer/WMS.js#L27

... which means that in GeoExt PrintProvider's WMS layer encoder, the version parameter won't go into the customParams, see https://github.com/geoext/geoext/blob/master/lib/GeoExt/data/PrintProvider.js#L651

As a result, I think it's better to have it alongside with the type = "WMS" parameter in the print spec.

from mapfish-print.

sbrunner avatar sbrunner commented on June 19, 2024

In booth case you should add the parameter then I don't see what it will change except to do it less generic ...

from mapfish-print.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.