Giter Club home page Giter Club logo

Comments (5)

bjorn avatar bjorn commented on June 23, 2024 1

I still don't like the silent failure, but maybe the point is moot with template support being added in the next version.

Yeah, I think at this point it's not really worth it making a new release that errors out on templates. 0.11 should be almost done (it's mainly still depending on the final solution for #37 - ggez integrates nicely now, but @aleokdev was still looking into integrating with Bevy).

from rs-tiled.

Aposhian avatar Aposhian commented on June 23, 2024

I think the issue is that the object templates are not being loaded properly, and so it silently defaults to dummy Rect objects. I would advocate that that be not a silent failure to a different shape type.

from rs-tiled.

aleokdev avatar aleokdev commented on June 23, 2024

On which version is this? (current / 0.10.2 does not have template support.)

from rs-tiled.

Aposhian avatar Aposhian commented on June 23, 2024

This was on 0.10.2 (without template support). I still don't like the silent failure, but maybe the point is moot with template support being added in the next version.

from rs-tiled.

aleokdev avatar aleokdev commented on June 23, 2024

It's not really a "feature", but rather done for compatibility with the TMX format. <object> doesn't need to contain a shape and so it defaults to a rectangle: https://doc.mapeditor.org/en/stable/reference/tmx-map-format/#object

I do agree that with the template attribute set this makes things a bit confusing, and perhaps we should've chosen to throw an error (or log a warning?) if the template parameter was set as there was no support for it. Changing this now to return an error could break loading for some users though, so I think it's better we just wait until the 0.11 release.

from rs-tiled.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.