`napi_get_property_names` is buggy in node 10.19 about vtshaver HOT 7 OPEN

Fix

Napi::String Napi::Value::ToString() const;

^^ Returns the Napi::Value coerced to a JavaScript string.
/cc @springmeyer

from vtshaver.

@artemp nice catch. Can you try to track down what change in node core fixed what you are seeing? Also, could this explain #40 ?

from vtshaver.

Also, could this explain #40

This btw seemed to me like a v8 behavior rather than node core or Nan related, but I'm not positive.

from vtshaver.

yep, #40 looks related. I'll investigate further and add workaround in our code if required.
/cc @springmeyer

from vtshaver.

thanks @artemp - I feel pretty good about #40 as a workaround, but let me know if you see a better one.

from vtshaver.

@springmeyer - re: #40 fix - ideally we shouldn't use v8 methods from N-api module.

from vtshaver.

ideally we shouldn't use v8 methods from N-api module.

Ah, good point.

from vtshaver.