Flow error in node_modules about underreact HOT 3 OPEN

Seems that we set configFile: false to disable babel to read external babel.config.js

from underreact.

@jingsam it is intentional not to compile non-standard Javascript (flow) in the node_modules. To get around this problem, you will have to manually compile mapbox-gl-style-spec like this:

// underreact.config.js
module.exports = {
  webpackConfigTransform: config => {
    injectGlStyleSpecLoader(config);
    return config;
  }
};

function injectGlStyleSpecLoader(webpackConfig) {
  const rulesOneOf = webpackConfig.module.rules.find(obj => obj.oneOf).oneOf;
  // The first loader is the regular javascript loader
  const myLoader = Object.assign({}, rulesOneOf[0], {
    exclude: undefined,
    include: new RegExp(
      '^' +
        path.resolve(
          __dirname,
          'node_modules/@mapbox/mapbox-gl-style-spec/(?!dist)'
        )
    )
  });
  rulesOneOf.unshift(myLoader);
}

from underreact.

@kepta Do you mean standard Javascript is the code that conform @mapbox/babel-preset-mapbox? I think the standard one is just use default babel setting, no other preset.

I think when users specify compileNodeModules: [] option, they definitely want to compile there modules by their project wide babel config. Don't you think your solution to compile mapbox-gl-style-spec is not elegant?

from underreact.