Set a flag for suspicious transformations over a certain threshold about osm-compare HOT 6 CLOSED

So is the answer here to change the vibe score at which this problem is reported? Where is that happening now in the code @planemad @batpad?

from osm-compare.

@mikelmaron we need to think about what a vibe represents, we currently use it as an indication of suspicion, but in certain cases, we can be sure it is definitely bad and the total vibe of a feature currently does not capture that. We could set an arbitrarily high score like -100, but as per @batpad a more sensible approach is to just set a flag of bad so that it can be treated separately from a suspicious feature.

The score -> vibe reporter is here: https://github.com/mapbox/vandalism-dynamosm/blob/master/util/reporter.js

cc @bkowshik

from osm-compare.

sensible approach is to just set a flag of bad so that it can be treated separately from a suspicious feature.

is that currently supported? would this automatically put that feature into escalated queue?

from osm-compare.

@mikelmaron not yet.

@batpad what do you think about escalating issues flagged invalid directly to the escalation queue? We should be able to start detecting confirmed displacements immediately with this.

from osm-compare.

@batpad following up from voice, lets do this!

• compare-geojson will set a new invalid=true flag for way or node displacements over 100m @planemad

Next we would need show these issues in a separate invalid queue in VH2 for review.

cc @bkowshik @mikelmaron

from osm-compare.

We do flag node drags.

from osm-compare.