Giter Club home page Giter Club logo

Comments (6)

tmcw avatar tmcw commented on May 20, 2024

Named needs to be named - modestmaps looks for .name as a property, and as such it can't be a function without very dangerous code, or a modestmaps tweak.

renderer could be valid, though it does refer to the factory pattern

markers.features refers to the features member of a GeoJSON feature collection, and markers.js aims to continue to support GeoJSON type objects internally, even if it supports other 'converters' to/from that format. data also could be confused with the data member in TileJSON.

addCallback and removeCallback are made to mirror modestmaps; I'd rather keep these continuous; they mirror addEventlistener in HTML and have been established for a while.

Hide on move, sure, works for me.

Template - no; this isn't templating, really: it doesn't take a template as an argument.

easey.toPoint I'd rather not use Point because it could be easily confused with MM.Point, which this has nothing to do with. open to other namings though

from mapbox.js.

tristen avatar tristen commented on May 20, 2024
  • Perhaps setPosition ? instead of toPoint ?
  • I know factory refers to the factory pattern but I feel like an api shouldn't bear its name - internally yes but not outwardly. the word, "render" attributes more closely to what it does I think.

from mapbox.js.

tmcw avatar tmcw commented on May 20, 2024

render is also a verb; you would expect markers.render() to render the markers. it would have to be markers.renderer() right?

from mapbox.js.

tristen avatar tristen commented on May 20, 2024

Ah I see. Yes, renderer

from mapbox.js.

tmcw avatar tmcw commented on May 20, 2024

Technically it's like an x value in http://en.wikipedia.org/wiki/Interpolation . Position is also kind of an overloaded term; unless we can find something that's accurate and specific, I don't really want to change this (plus it's a pro feature anyway)

from mapbox.js.

tmcw avatar tmcw commented on May 20, 2024

We're supporting camelCase in v1 and such.

from mapbox.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.