Improve the monitoring of step progress about mapbox-navigation-android HOT 3 CLOSED

Sounds great. It’s a sprawling method that should be refactored on the Swift side too.

from mapbox-navigation-android.

I've been looking over best solutions for splitting up the monitorStepProgress, here are the steps I'm thinking of taking to refactor it.

• Move logic into it's own class and get rid of LocationUpdateThread (see #19).
• Have routeProgress handle more logic, currently in monitorStepProgress() we are doing conversions and calculations that seem fit for handling inside the routeProgress model instead such as calculating the users location truePosition, secondsToEndOfStep, etc. This would require building a new routeProgress object before determining what alert level the users on and invoking the callbacks appropriately.
• Each alert level check moved into separate methods. This can help remove unnecessary checks such as whether the user just departed or not, which only needs to be called once. This also makes testing of each method significantly easier.

from mapbox-navigation-android.

Refactoring of this took place in #30. Closing.

from mapbox-navigation-android.