Comments (3)
I'd prefer like option 1. I don't think this migration would be too bad from Studio's POV and we'd come out of it with simpler, clearer CSS.
from assembly.
Agree with option 1, let's tear the band-aid off!
from assembly.
I think deprecating flex-child
makes sense. Should we consider dropping the word parent
from the flex-parent modifiers as well?
Right now the flex classes distinguish between parent and child. If we switch from flex-child--grow
→ flex-grow
then the naming convention is lost on the child classes, but remains with the parent classes.
Additional ideas:
-
Deprecate
flex-child
and removechild
andparent
from remaining classes. This is a pattern Tailwind uses. While this change would more closely follow patterns of other Assembly classes, it would increase the amount of breaking changes.
Example:flex-parent
→flex
Example:flex-child--grow
→flex-grow
-
Deprecate
flex-child
and keepchild
in remaining classes. This option would reduce the amount of breaking changes and keep the parent/child naming convention.
Example:flex-child--grow
has no change
from assembly.
Related Issues (20)
- Icon for boolean
- 1.0.0 migration guide
- Switch handles are not perfect circles
- loading--dark modifier not working as expected HOT 1
- css and js CDN addresses are 404 HOT 1
- Remove `flex-grow` from `.col` HOT 1
- assembly.min.css missing `border-top-color` in `.loading--dark` HOT 1
- Add `flex-basis: 0;` to col--auto
- Create ESLint plugin for using Assembly with React HOT 1
- Consider setting color-scheme to opt-out of Chrome Auto Dark Themes HOT 1
- Dependency on specific npm Version
- Do we need to resolve custom properties? HOT 1
- Rework range input so track is easier to click HOT 5
- Make it easier to style borderless select elements HOT 3
- Remove `btn--stroked--2` and `select--stroked--2`? HOT 1
- Rework color variants in order to reduce file size HOT 1
- Implement gutter classes with CSS grid instead of using margin/padding hacks HOT 2
- Can we deprecate flex-child?
- Improve focus states for text inputs and textareas
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from assembly.