Giter Club home page Giter Club logo

Comments (3)

samanpwbb avatar samanpwbb commented on September 22, 2024 1

I'd prefer like option 1. I don't think this migration would be too bad from Studio's POV and we'd come out of it with simpler, clearer CSS.

from assembly.

dereklieu avatar dereklieu commented on September 22, 2024 1

Agree with option 1, let's tear the band-aid off!

from assembly.

katydecorah avatar katydecorah commented on September 22, 2024

I think deprecating flex-child makes sense. Should we consider dropping the word parent from the flex-parent modifiers as well?

Right now the flex classes distinguish between parent and child. If we switch from flex-child--growflex-grow then the naming convention is lost on the child classes, but remains with the parent classes.

Additional ideas:

  1. Deprecate flex-child and remove child and parent from remaining classes. This is a pattern Tailwind uses. While this change would more closely follow patterns of other Assembly classes, it would increase the amount of breaking changes.
    Example: flex-parentflex
    Example: flex-child--growflex-grow

  2. Deprecate flex-child and keep child in remaining classes. This option would reduce the amount of breaking changes and keep the parent/child naming convention.
    Example: flex-child--grow has no change

from assembly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.