Comments (17)
You are absolutely right. This is a bit more difficult since ListReleaseNamesInNamespace
is in another package - helm-plugin-utils
.
To make things more simple, I have updated the utils
package (with tag 0.1.2).
If you want to take it from here - you are welcome ;)
The backup plugin is using dep
for package management. Here are some links to help you with that:
https://golang.github.io/dep/docs/introduction.html
https://golang.github.io/dep/docs/Gopkg.toml.html#constraint
Again, if you prefer I do it - just say the word.
Thanks!
from helm-backup.
Hey @devteng,
That's a great find! :)
I have added the label good first issue
. Would you like to give it a try?
If not, that is ok, I can fix it.
Would you like to get involved? ;)
from helm-backup.
I will give it a shot! Will scream for help if I need help.
from helm-backup.
Hi maorfr, I am not able to build this code. Mostly likely due to me being a novice to golang and not having a proper golang environment. What I am suspecting is that the tiller namespace is not being passed into ListReleases(ListOptions{})
in the func ListReleaseNamesInNamespace.
func ListReleaseNamesInNamespace(namespace string) (string, error) { releases, err := ListReleases(ListOptions{}) if err != nil { return "", err } uniqReleases := make(map[string]string) for _, r := range releases { if r.Namespace != namespace { continue } uniqReleases[r.Name] = "" } var inReleases string for k := range uniqReleases { inReleases += k inReleases += "," } return strings.TrimRight(inReleases, ","), nil }
from helm-backup.
Thanks maorfr! For now, please work on it. I need to spend more time with golang before I take this on. I very much appreciate your work!
from helm-backup.
Your appreciation is appreciated ;)
The issue is fixed with version 0.1.1, give it a shot.
from helm-backup.
Closing this issue, feel free to reopen if it isn't fixed :)
from helm-backup.
This isn't fixed. I'm experiencing the issue with version 0.1.1
My label default OWNER=TILLER as well. And my tiller-namespace is not kube-system
from helm-backup.
Would love to see some output from the command execution!
from helm-backup.
I think I am facing a similar issue.
For a command looking like helm backup whatever-namespace --tiller-namespace my-tiller-namespace
, I get:
2019/04/08 09:26:40 getting tiller storage
2019/04/08 09:26:40 Found 0 tiller pods
Error: plugin "backup" exited with error
I feel like it basically ignore both --tiller-namespace
options or TILLER_NAMESPACE
env variable, I've tried both.
It works flawlessly with kubte-system
as my tiller-namespace though.
from helm-backup.
can i please get a printout of describe
of the tiller pod in the my-tiller-namespace
namespace?
from helm-backup.
Name: tiller-deploy-664669fff8-6lcd6
Namespace: my-tiller-namespace
Priority: 0
PriorityClassName: <none>
Node: cancun/10.46.1.109
Start Time: Mon, 04 Mar 2019 09:55:01 +0100
Labels: app=helm
name=tiller
pod-template-hash=664669fff8
Annotations: <none>
Status: Running
IP: 10.244.6.99
Controlled By: ReplicaSet/tiller-deploy-664669fff8
Containers:
tiller:
Container ID: docker://eb6c8a9fc276911226cdd8bb59530ed25e5bd4f6453952d38a1f835677b49526
Image: gcr.io/kubernetes-helm/tiller:v2.13.0
Image ID: docker-pullable://gcr.io/kubernetes-helm/tiller@sha256:c4bf03bb67b3ae07e38e834f29dc7fd43f472f67cad3c078279ff1bbbb463aa6
Ports: 44134/TCP, 44135/TCP
Host Ports: 0/TCP, 0/TCP
State: Running
Started: Fri, 22 Mar 2019 17:22:51 +0100
Last State: Terminated
Reason: Error
Exit Code: 2
Started: Mon, 04 Mar 2019 10:17:33 +0100
Finished: Fri, 22 Mar 2019 17:02:49 +0100
Ready: True
Restart Count: 2
Liveness: http-get http://:44135/liveness delay=1s timeout=1s period=10s #success=1 #failure=3
Readiness: http-get http://:44135/readiness delay=1s timeout=1s period=10s #success=1 #failure=3
Environment:
TILLER_NAMESPACE: my-tiller-namespace
TILLER_HISTORY_MAX: 0
Mounts:
/var/run/secrets/kubernetes.io/serviceaccount from tiller-token-v6tds (ro)
Conditions:
Type Status
Initialized True
Ready True
ContainersReady True
PodScheduled True
Volumes:
tiller-token-v6tds:
Type: Secret (a volume populated by a Secret)
SecretName: tiller-token-v6tds
Optional: false
QoS Class: BestEffort
Node-Selectors: <none>
Tolerations: node.kubernetes.io/not-ready:NoExecute for 300s
node.kubernetes.io/unreachable:NoExecute for 300s
Events: <none>
I have 3 pods (due to my helm config which has a replica count of 3) for your knowledge, maybe this is related.
EDIT: I also tried with the -l name=tiller
or app=helm
option, and the output is the exact same.
from helm-backup.
hi guys, added PR for the problem #8
from helm-backup.
closing as the PR is merged. thanks!
from helm-backup.
You have merged this commit, but it seems like if I install using helm plugin
as below, I still get the old 0.1.1
helm plugin install https://github.com/maorfr/helm-backup
Only when I build locally then I get the fixed version. Can you check on this? Thanks!
from helm-backup.
i just release 0.1.2. give it another try.
from helm-backup.
Cool...working fine now...thanks a lot!
from helm-backup.
Related Issues (15)
- one tool to export/import HOT 5
- The ConfigMap is invalid: metadata.annotations: Too long: must have at most 262144 characters HOT 1
- awk Error on install
- Can this be used to migrate tiller configmaps from one namespace to another HOT 1
- Support for Helm v3 HOT 2
- Release the last version HOT 1
- Not able to backup specific release from namespace
- Update version in plugin.yaml
- No Auth Provider found for name "azure" HOT 4
- Not working with microk8s installation (conjure up) HOT 2
- Plugin does not support multi path KUBECONFIG env var HOT 1
- Error: unknown flag: --kubeconfig HOT 2
- Install plugin in macOS
- Couldn't restore due to config map conflict HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm-backup.