Giter Club home page Giter Club logo

Comments (1)

manuc66 avatar manuc66 commented on May 18, 2024

Hi @CK-Yong

Thanks for submitting this issue

I don't agree with the expectation that unregistered base class should serialize their class name because the "discriminator's value" may be numeric or have a specific naming convention (with specific prefix/suffix or another)

When using JsonSubtypesConverterBuilder all sub types should be registered:

          var serializersettings = new JsonSerializerSettings();
            serializersettings.Converters.Add(
                JsonSubtypesConverterBuilder
                    .Of(typeof(Animal2), "Type")
                    .SerializeDiscriminatorProperty()
                    .RegisterSubtype(typeof(Animal), typeof(Animal).Name)
                    .RegisterSubtype(typeof(Cat), typeof(Cat).Name)
                    .Build());

However, I agree that the exception KeyNotFoundException is not explicit enough and should be fixed

from jsonsubtypes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.