Comments (7)
dwrensha
commented on June 19, 2024
from compiletest-rs.
oli-obk
commented on June 19, 2024
I've been wondering about that.
from compiletest-rs.
laumann
commented on June 19, 2024
Would the change in #66 have any effect elsewhere?
from compiletest-rs.
dwrensha
commented on June 19, 2024
I suppose someone could try running the change (#66) on the crates that depend on compiletest: https://crates.io/crates/compiletest_rs/reverse_dependencies --- something like a mini crater run. (cc @shepmaster, who I think at one point was wondering whether automation for such testing might be useful.)
I think the main things we should worry about are causing tests to fail silently and causing tests to be unexpectedly ignored. It seems unlikely to me that this change would result in either. Meanwhile, compiletest's current behavior is causing tests to be unexpectedly ignored right now out in the wild, as the miri code linked above shows.
from compiletest-rs.
dwrensha
commented on June 19, 2024
c.f. #13, where the target field default behavior was added.
Why would the default have the target set from rustc, but have a "(none)" value in host?
from compiletest-rs.
laumann
commented on June 19, 2024
I see your point wrt #13 - I'll merge #66
from compiletest-rs.
laumann
commented on June 19, 2024
https://crates.io/crates/compiletest_rs/0.2.7 is out!
from compiletest-rs.
Related Issues (20)
- Support normalization of $SRC_DIR HOT 2
- Fails to build with latest rustc
- Remove all references to "stable" feature
- run-pass tests with non-zero exit code is considered passing HOT 6
- Overwriting "-Aunused" does not work any more HOT 3
- panic if TERM environment variable is "dumb" HOT 5
- Filter testcases by regex instead of by (sub)string HOT 1
- Move to Github Actions HOT 1
- Adding `bless` support HOT 2
- Can't run compiletests on Mac when `DYLD_LIBRARY_PATH` is unset or empty HOT 1
- Human-readable output HOT 1
- Moving repository out HOT 11
- Remove dependency on `test` crate HOT 1
- Unify with in-tree compiletest-rs HOT 7
- Adding a CHANGELOG
- Allow certain lints in `.fixed` compile test HOT 3
- does not build if HOST is not set HOT 1
- cd test-project && cargo +nightly hack test --feature-powerset fails with duplicate rlibs
- [Question] how do I get compiletest-rs to find the parent crate? HOT 2
- Cross-compilation support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compiletest-rs.