Create a test to certify a clean install about manim HOT 14 CLOSED

@naveen521kk all tests should be done via pytest, as much as possible.

from manim.

Could probably be automated with travis or something as well

from manim.

As @leotrs pointed out, we will have to be aware in the tests that Latex is optional. See #11

from manim.

Closed since #28 #97 are on this (and more up-to-date)

from manim.

@huguesdevimeux While this can be done with what we currently have, I don't think this has been implemented. To clarify, I meant a "test to certify a clean install" that a user could run after installation, and it would be part of the installation instructions. So the installation instructions would have this as the last instruction: "Finally, run some_command on your terminal. If it finishes without error, then your install of manim is complete. If it shows an error, then please refer to the FAQ/Troubleshooting section".

So I guess all that's missing in order to get that is documentation.

from manim.

@leotrs Oh ok I see, this is a good idea.
But is your idea to do it with pytest ? If yes I think this will be implemented soon.
If not, I think that just telling the user to run SquareToCircle might be enough.
But you're totally right, at least a mention of a such command (potentially with SquareToCircle, I don't know) is missing in the Readme.

from manim.

I have to agree with @leotrs that this isn't finished yet, and it would ideally be something done through pytest. It'd be much better to have a command which gives clear error messages and covers as many potential pitfalls as it can than to run SquareToCircle. As an example, the latter wouldn't test latex.

from manim.

Will a batch/shell script do? Or it should be done with purest?

from manim.

@naveen521kk all tests should be done via pytest, as much as possible.

Hmm are you sure about that ? I mean, this test is meant to be run by a standard user, not a contributor.
I think a shell script is better as there is much more trouble to set up.

What do you think ?

from manim.

So in the PR I just requested (#324), there are instructions embedded in the installation instructions to certify the installation is clean. For example, after installing latex, it instructs the reader to try it out by executing latex on the console. Would this be a poor man's fix for this issue?

from manim.

Why can't we ask them to use pytest, like you suggested?

Heck, we could have a script in /scripts/ install pytest for them, run the tests, make sure they're fine, and uninstall pytest on the way out.

from manim.

I mean, we can 🤷‍♂️

from manim.

I think this issue went off the rails a little bit. The original idea is to provide a way for end users to test whether or not their installation is clean. They usually don't have pytest installed. I think having a script that ships with the library, or even a subcommand manim certify-install is the way to go.

OTOH, the documentation already includes instructions on how to certify the installation of each dependency. I think it's safe to close this issue for now. @Aathish04 ?

from manim.

I think the current documentation does a good job at guiding the user through the whole installation process.

I think this issue has ran its course.

from manim.