Comments (9)
Seems kinda lame. I'll take a look at it.
I think it's due to the gem trying its best to strip Roadie options from the headers. How do you add the headers so I can write a test for it?
from roadie.
I simply do the following (I've also tried to add it to the hash of the mail method):
def send_email(subscribers)
subscribers = [subscribers] unless subscribers.is_a?(Array)
# Set recipients with SendGrid SMTP API
# http://wiki.sendgrid.com/doku.php?id=smtp_api
headers["X-SMTPAPI"] = {
:to => subscribers.map(&:email)
}.to_json
mail(:to => "[email protected]", # ignored by SendGrid (errors will be sent here).
:subject => "Newsletter" )
end
from roadie.
This is now confirmed and I have a working test for it.
For the record, saying headers["..."] = ...
does not work since it only assigns to a local variable. What you meant to write is headers("..." => ...)
.
from roadie.
Could you test the version in master right now and see how it works? If it works for you I'll release this as version 1.0.0.
from roadie.
Sorry for not getting back to you before now - I have a major release (go live) on Thursday so I won't have time to integrate/test Roadie before the weekend. But thanks in advance for fixing the issues!
Regards,
Nicholas
from roadie.
Alright.
If you need to manually patch it before release, take a peek at the commit that fixed this problem: 7ed0d50
from roadie.
Hey, sorry for the late reply - we had a lot of post deployment stuff so it took a while before I could take another look at Roadie. It seems to work fine now - thanks!
from roadie.
Glad to hear it. I'll release this in a bit.
from roadie.
FYI: I've released 1.0.0 now.
from roadie.
Related Issues (20)
- undefined method `children' for nil:NilClass HOT 13
- Support css_parser 1.4.x HOT 2
- Support Outlook's approach to margins HOT 2
- Media queries inlined HOT 9
- Roadie is erratically causing emails to be encoded differently HOT 3
- New release supporting Nokogiri 1.7? HOT 2
- Weird issue with content: '•'; in my CSS HOT 4
- Convert rem to px? HOT 1
- Allow anchor tags to be ignored HOT 3
- nokogiri is locked to 1.7.x, 1.8.x is out. HOT 5
- css_parser is locked to 1.4.x, 1.5.x is out HOT 6
- Add support for storing the document as XHTML HOT 3
- Stylesheet BOM stripping doesn't work with NetHttpProvider HOT 8
- support anchor/ image url stripping inside conditional tags HOT 5
- Image style attributes - Outlook (on windows) special cases HOT 1
- Transformation Hooks - readme out of date HOT 2
- [Announcement] Passive maintenance mode HOT 6
- Roadie output mangled when control chars are present in conditional comments HOT 1
- NoMethodError Exception: undefined method `match' for #<Hash:0x00000000062ecdf8> HOT 3
- Support CSS custom properties (variables) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roadie.