Support for named columns about typeorm-graphql-loader HOT 4 CLOSED

Cheers @Mando75! really awesome package by the way, this fits most of my use case in my current project 👍 I will try to contribute more.. of course through gitlab.

from typeorm-graphql-loader.

Thanks for the PR. I'll take a look at it tonight and run it through some more tests. Assuming everything works correctly I'll get your PR merged and a patch published tonight.

EDIT: Sorry didn't mean to close the issue. Fat fingers :/

from typeorm-graphql-loader.

Just one other note here, as mentioned in the CONTRIBUTING section of the README, this GitHub repo is actually just a mirror of a GitLab repo where the development actually takes place. As such, I can't actually merge the PR in GitHub as all of the deployment/publishing pipelines won't get run in GitLab. If you have a GitLab account, I encourage you to open an MR for this repository https://gitlab.com/Mando75/typeorm-graphql-loader. Otherwise, I can just pull in your changes as a feature branch and handle merging it that way.

from typeorm-graphql-loader.

Took a look through everything and it seems to work great. I did have to make a couple tweaks to get it to work correctly with embedded entities as well, but I'm shipping the fix here in a minute under version 1.1.1 of the package. Like I mentioned, I actually ship the package through GitLab, so I will close this issue and your PR. Rest assured, you fix made it in though. Thanks again for bringing this up. :)

from typeorm-graphql-loader.