Giter Club home page Giter Club logo

Comments (9)

vatsalparekh avatar vatsalparekh commented on August 11, 2024

@pkliczewski @masayag this is specifically for #62

from manageiq-providers-kubevirt.

vatsalparekh avatar vatsalparekh commented on August 11, 2024

@pkliczewski Because of this, I can't check #72 for #62
Would suggest if you can fix this one before merging #62

from manageiq-providers-kubevirt.

pkliczewski avatar pkliczewski commented on August 11, 2024

It looks like it works from time to time. We need to understand what is breaking it.

from manageiq-providers-kubevirt.

pkliczewski avatar pkliczewski commented on August 11, 2024

I checked and when there is not correct token in parent provider we are unable to save valid token in the child provider.

from manageiq-providers-kubevirt.

vatsalparekh avatar vatsalparekh commented on August 11, 2024

From the latest findings, the reproducible pattern is that, if the auth status for default token of openshift is still valid, then save button will appear when editing the infra provider, but if the status is ! then it will not let you save the new correct token for virtualization.
Checked it without the fog-kubevirt, so this is not regression, but a bug rather.

from manageiq-providers-kubevirt.

vatsalparekh avatar vatsalparekh commented on August 11, 2024

@miq-bot add-label bug

from manageiq-providers-kubevirt.

vatsalparekh avatar vatsalparekh commented on August 11, 2024

@masayag @pkliczewski this one is still reproducible on latest master

from manageiq-providers-kubevirt.

masayag avatar masayag commented on August 11, 2024

Reopen the issue - should be closed once ManageIQ/manageiq-providers-kubernetes#259 is merged.

from manageiq-providers-kubevirt.

masayag avatar masayag commented on August 11, 2024

The only use case in which the issue might occur after merging the previous PRs is when the parent provider token is invalid, while kubevirt's token is valid.

The assumption is that both kubevirt and the container manager provider tokens should be valid.
The options are to verify parent provider token is valid when checking kubevirt validation or to disable the ability to edit kubevirt provider.

The other use-cases are handled by the merged PRs.

from manageiq-providers-kubevirt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.