Comments (3)
You're right.. and I've come across this fact before (the spec even suggests to omit the extra_field data for the LFH and only place it in the CDR if it needs to be private - via CD encryption) but somehow forgot about it when doing the re-write.
I would really like to keep the ability to skip reading the LFH in cases like these where it's not really needed, but I don't think there's any way around it. I'll see if I can come up with any clever ideas.
from rs-async-zip.
I'd be curious to see if you come up with something, but it may not be worth the effort.
As far as I know, the LFH + trailing data is usually fairly small (maybe in the range of ~20 to 30 bytes). And it immediately precedes the data you're going to read anyway to decompress the file.
Reading the LFH separately before decompression will cause extra read operations, but there are ways to get rid of those.
For example, you could share a BufReader between the LFH parsing code and the decompression code. In most cases, this should make the reads issued to the underlying reader the same as the current code.
This is because the decompression code currently uses a BufReader with the default buffer size (8kb). Since the the LFH + trailing data is significantly smaller than this buffer size, reading the LFH immediately before decompression shouldn't generally have an impact on the number of reads.
Unfortunately, I don't think there are any clever ways of avoiding reading the LFH in general (I can elaborate more on this with examples if you'd like), but the solution I described above should basically provide equivalent performance characteristics to the current code.
from rs-async-zip.
Just checking if you're okay with something like this.
I'm happy to implement the above solution if you'd like
from rs-async-zip.
Related Issues (20)
- deflate64 support
- Support to read Info-ZIP Unicode Path Extra Field HOT 1
- Incorrect Zip64 Header Implementation HOT 8
- Tokio file doesn't satisfy `tokio::fs::File: futures_lite::AsyncWrite` HOT 1
- Incorrect parsing of zip64 extended information field HOT 1
- New Release? HOT 3
- Offset and size of entry in archive HOT 1
- Parallel Zip Stream support HOT 2
- Async ZIP Streaming?... HOT 13
- Test failures on 32-bit arches HOT 2
- data descriptor not supported error HOT 11
- Broken pipe occurs. HOT 4
- Streaming - Write file in chunks HOT 2
- Option to compress externally and just store input compressed byte stream.
- a computed CRC32 value did not match the expected value - when CRC is in data_descriptor HOT 2
- Can't properly use the stream method
- SPECIFICATION.md is not redistributable HOT 3
- A way to `write_entry_stream` while retaining valid local file headers
- `tokio::io::AsyncRead`(`Ext`) doesn't seem to be implemented for `async_zip::tokio::read::ZipEntryReader` HOT 2
- OwnedEntryStreamWriter HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rs-async-zip.