There are some issues that I can see coming from the fact that GPS_NMEA_parser

Floating Point Types about lwgps HOT 3 CLOSED

temporaryaccount commented on June 28, 2024

Floating Point Types

from lwgps.

Comments (3)

MaJerle commented on June 28, 2024 1

Done.

from lwgps.

MaJerle commented on June 28, 2024 1

Hmm, this I added and somehow reverted.

from lwgps.

temporaryaccount commented on June 28, 2024

That's incredible, thank you!

If it's not too much, can I suggest one more thing?

Current:

static gps_float_t
parse_float_number(gps_t* gh, const char* t) {
    double res;

    if (t == NULL) {
        t = gh->p.term_str;
    }
    /* Strip leading spaces */
    while (t != NULL && *t == ' ') {
        t++;
    }
    res = strtod(t, NULL);                      /* Parse string to double */
    return FLT(res);                            /* Return casted value, based on float size */
}

Suggestion:

static gps_float_t
parse_float_number(gps_t* gh, const char* t) {
    gps_float_t res;

    if (t == NULL) {
        t = gh->p.term_str;
    }
    /* Strip leading spaces */
    while (t != NULL && *t == ' ') {
        t++;
    }

#if GPS_CFG_DOUBLE
    res = strtod(t, NULL);                      /* Parse string to double */
#else /* GPS_CFG_DOUBLE */
    res = strtof(t, NULL);                      /* Parse string to double */
#endif /* GPS_CFG_DOUBLE */

    return FLT(res);                            /* Return casted value, based on float size */
}