Comments (1)
BlueCutOfficial
commented on June 14, 2024
Hi, thanks for opening this.
Our team had a look at the suggestion but preferred not to implement it. Our reasoning is that preventing the modal from being closed should be managed from the modal itself, so the close action should not be called in the first place if there are validation errors and such. If it's not possible for some reason, it's still possible to extend the addon's functionalities.
We prefer to not change the addon's public API that way unless this use case comes up frequently.
from ember-promise-modals.
Related Issues (18)
- focus should return to origin element when modal is closed HOT 4
- Replace travis-ci with GitHub actions HOT 1
- Replace `Dependabot Preview` with `Dependabot` HOT 1
- Decorator being a barrier to be able to use it with previous Ember versions HOT 3
- Option to opt-out from Focus Trap HOT 5
- Move to v2 addon format HOT 1
- Add documentation for Modal instance
- Update CI config to include ember 4 HOT 1
- Installing this package from Git using Yarn Berry v3.1.0 fails HOT 5
- Latest focus trap changes causes the modal response to be lost HOT 1
- Dependency Dashboard
- Add an incoming animation end hook
- Modal stays in DOM after closing HOT 10
- testWaiter.endAsync fails (needs reproduction) HOT 1
- Focus is immediately applied on open, may cause trouble! HOT 2
- `prefer-reduced-motion` stops modals from closing on `main`
- Should we allow calling the close callback more than once? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-promise-modals.