Comments (5)
Hm, when you're not writing the cookie for a specific path it should actually also not be necessary to include the path when clearing. However, I think we should support some of the arguments we support for regular writing for clearing as well - specifically path
, domain
and secure
.
Would you submit a PR adding support for those?
from ember-cookies.
Happy to do that! I'm just not an expert in cookies, that's why I only reported the issue and not submitted the PR already :)
from ember-cookies.
Awesome! Let me know if you need help.
from ember-cookies.
@marcoow could you please review #197?
from ember-cookies.
any chance @marcoow could cut a new release to include #197? This particular issue just bit me as well. For whatever reason, headless chrome (in test contexts only, works ok using it on the CLI), seems to require the path option for clearing.
from ember-cookies.
Related Issues (20)
- Expire On Cookie HOT 1
- DEPRECATION: Use of `merge` has been deprecated HOT 2
- An in-range update of ember-cli-babel is breaking the build 🚨 HOT 3
- Fastboot causes double decoding HOT 2
- Addon causes linked apps to error during build. "Babel loaded v6.x.x" HOT 1
- npm deploy build step failed HOT 2
- `Cannot read property 'split' of undefined` error in tests when upgrading to ember 3.13.0 HOT 1
- [0.5.1 Regression] TypeError: Cannot read property 'isFastBoot' of undefined HOT 1
- Add SameSite=None support (and UA check?) HOT 3
- nodetest task HOT 1
- Setting max age in FastBoot
- Add a timeout to CI GitHub workflow for test step
- cookies not working
- Dependency Dashboard
- Cut new release HOT 3
- Convert addon to V2 HOT 2
- TypeError: can't access dead object HOT 2
- Ember v5 - current ember-canary, ember-beta channels are failing under fastboot HOT 1
- [Embroider] Fails under fastboot in embroider-optimized scenario
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cookies.