ruby syntax filters do not work properly about mailjet-gem HOT 9 CLOSED

I'll have a look at the filters and check it's not API related, thanks for bringing this up

from mailjet-gem.

I've done few tests with curl against the contact resource.
Using filters works with query string but not with json payload. Maybe this could explain the issue.
The API documentation is not really explicit around this.

from mailjet-gem.

Awesome - thanks for that, we'll look into it.

Much appreciated.

from mailjet-gem.

Ah, ok, I see what's happening here - when you use:

Mailjet::Contact.all('ContactsList' => remote_list.id)
#or
Mailjet::Contact.all(:contactslist => remote_list.id)

The filters passed in are formatted into a query string by the gem.
When the filters are correctly formatted:

https://api.mailjet.com/v3/REST/contact?contactslist=1

You get the required response.

When the filters are incorrect, the API ignores them, for instance if a raw API call is something like:

# A GET to:
https://api.mailjet.com/v3/REST/contact?contcatlis=1

It then defaults to what is effectively:

Mailjet::Contact.all

And you get the 'all' call for the resource.

I think implementing filter checking could be quite challenging as there are so many over so many resources, so it might be best to add a note to the readme.

You are correct, the API does not support filtering by JSON payload.

Hope that helps, all the best,

Toby

from mailjet-gem.

What lead to confusion is this : https://github.com/mailjet/mailjet-gem#naming-conventions

When I use :contact_list as a filter I expect it to be sent as ContactList and the query should succeed.
The issue I think is that filters are not converted to camelcase.

from mailjet-gem.

You're quite right - I'll have a look through previous commits and see what changed.

from mailjet-gem.

Hi !

Sorry for the delay, and thanks for that relevant issue. You might take a look at the filters branch, which we are soon going to release into master. It automatically convert :snake_case_symbols into 'CamelCaseString' so both of your examples would work !
You may need to consider a few days before the merge, but you can already use the feature.

Regards,
Guillaume

from mailjet-gem.

Hi @Electron-libre !

If you have any other suggestion, i would be happy to help ! Otherwise, please consider closing the issue :)

Regards,
Guillaume

from mailjet-gem.

Hi,
Sounds great. Thanks for your feedback and fixes.

Kind Regards

from mailjet-gem.