Mailjet::Resource find method can never return nil about mailjet-gem HOT 5 CLOSED

Proposed change :

      def find(id)
        attributes = parse_api_json(connection[id].get(default_headers)).first
        instanciate_from_api(attributes)
      rescue Mailjet::ApiError => e
        if 404 == e.code
          nil
        else
          raise e
        end
      end

from mailjet-gem.

Thanks for your feedback! Let me check this out

from mailjet-gem.

Hi,

So I've tested out your code and it seems to throw an error message when I try to find a resource that exists. Is there anything else I can add for this?

from mailjet-gem.

Have you tested from my fork ?

from mailjet-gem.

Fixed!

from mailjet-gem.