Comments (3)
@ajpetersons open to PR's to fix this ๐
Not sure how it could be done without a breaking change without looking into it in more detail
from mailerlite-go.
Would exporting the rootSubscriber
ย and similar types that are returned by operations actually be breaking change for package users? Access to fields would remain the same, access to methods would be possible only if the method is exported. In my code I am unable to declare variable of type *rootSubscriber
right now because that's an internal type, so there shouldn't be any issues with that. Maybe I'm missing something, please correct me if so.
The main benefit with this change would be that then I can write my own interface that SubscriberService implements. In main code I would supply struct from this package, but in unit tests I can use any struct I like as long as it satisfies the interface.
from mailerlite-go.
i suppose it would not be a breaking change thinking about this, could you maybe create a PR with what you are suggesting I will be happy to accept this if there are no breaking changes for users.
from mailerlite-go.
Related Issues (15)
- [SDK] Create the Campaigns endpoints - Go HOT 1
- [SDK] Create the Groups endpoint - Go
- [SDK] Create the Segments endpoint - Go HOT 1
- [SDK] Create the Fields endpoint - Go
- [SDK] Create the Forms endpoint - Go HOT 1
- [SDK] Create the Stats endpoint - Go HOT 1
- [SDK] Create missing endpoints - Go HOT 1
- [SDK] Create Webhook endpoints - Go HOT 1
- Error unmarshaling campaign list -- wrong type for 'settings' field HOT 2
- Subscriber creation function is broken
- Campaign scheduling function ignrores TimezoneID HOT 4
- Dependency Dashboard
- Error when trying to add new Subscriber HOT 3
- Limit & Page is useless on Fetch List subscribers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mailerlite-go.